Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Added support for reverse function #17951

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

Napalys
Copy link
Contributor

@Napalys Napalys commented Nov 11, 2024

While addressing another issue I found that we we're missing support for Array.prototype.reverse.
I've added support for the method, and moved an existing related support for .sort() to a more relevant location.

@github-actions github-actions bot added the JS label Nov 11, 2024
@Napalys Napalys marked this pull request as ready for review November 11, 2024 09:17
@Napalys Napalys requested a review from a team as a code owner November 11, 2024 09:17
@Napalys Napalys changed the title Added support for reverse function JS: Added support for reverse function Nov 11, 2024
@@ -446,12 +446,12 @@ private module ArrayLibraries {
}

/**
* A taint propagating data flow edge arising from sorting.
* A taint propagating data flow edge arising from in-place array manipulation operations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe here add that the methods also return the pointer to this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in 38d3e37.

@erik-krogh
Copy link
Contributor

@Napalys Napalys merged commit 6266dab into github:main Nov 12, 2024
13 checks passed
@Napalys Napalys deleted the napalys/reverse-support branch November 12, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants