-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS: Added support for reverse function #17951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lagged as a potential sink.
…ort both sort and reverse functions. Fixed newly added test case. from 8026a99
Napalys
changed the title
Added support for reverse function
JS: Added support for reverse function
Nov 11, 2024
erik-krogh
reviewed
Nov 11, 2024
@@ -446,12 +446,12 @@ private module ArrayLibraries { | |||
} | |||
|
|||
/** | |||
* A taint propagating data flow edge arising from sorting. | |||
* A taint propagating data flow edge arising from in-place array manipulation operations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe here add that the methods also return the pointer to this
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 38d3e37.
Note to self: The DCA experiment with meta-queries is also clean. |
Napalys
force-pushed
the
napalys/reverse-support
branch
from
November 11, 2024 14:38
2c849b5
to
38d3e37
Compare
Napalys
force-pushed
the
napalys/reverse-support
branch
from
November 11, 2024 14:39
38d3e37
to
42f7f73
Compare
erik-krogh
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While addressing another issue I found that we we're missing support for
Array.prototype.reverse
.I've added support for the method, and moved an existing related support for
.sort()
to a more relevant location.