Rust: Account for captured variables #17696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/captured-variables
branch
from
381caf9
to
5afd2d5
Compare
geoffw0
reviewed
Oct 9, 2024
aschackmull
reviewed
Oct 16, 2024
| } | ||
|
|
||
| /** Same as `DenseRank`, but allows for a context consisting of one element. */ | ||
| module DenseRank2<DenseRankInputSig2 Input> { |
There was a problem hiding this comment.
Would the naming perhaps be a bit better if the numbering was shifted? I.e. DenseRank1 here to indicate a size one context?
aschackmull
reviewed
Oct 16, 2024
| } | ||
|
|
||
| /** Gets the dense rank of `r` in the context provided by `c1` and `c2`. */ | ||
| int denseRank(C1 c1, C2 c2, Ranked r) { |
There was a problem hiding this comment.
I think perhaps I would have swapped the rank and the Ranked columns, so the Ranked would be the result, same as with the builtin aggregate.
There was a problem hiding this comment.
Whether to similarly swap in the input predicate, I don't know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AST logic for identifying captured variables.
I identified and fixed two bugs as well:
variableAccessCandInScope, as the comment says.rankbeing potentially non-dense, by applying a newly introducedDenseRanklibrary.