Swift: Make Callable a sub type of AstNode
#17463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
swift/callable-ast-node
branch
from
9722356
to
7444027
Compare
redsun82
reviewed
Sep 16, 2024
There was a problem hiding this comment.
let's not worry about upgrade/downgrade scripts, we will start doing those only when we promise stability
There was a problem hiding this comment.
Note: This is Swift, not Rust.
There was a problem hiding this comment.
aaaah I think I need a second coffee 😅
redsun82
reviewed
Sep 16, 2024
redsun82
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
Callablewas manually made a sub class ofAstNodeinswift/ql/lib/codeql/swift/elements/Callable.qll. This PR adjustsschema.pyto reflect that.