C#: Fix glob pattern processing: allow **/ to match empty string
#16895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
reviewed
Jul 3, 2024
| if (i + 2 < pattern.Length) | ||
| { | ||
| // Processing .../**/... | ||
| sb.Append("(.*/|)"); |
There was a problem hiding this comment.
I had took look at this a while for parsing it: It is an alternation construct that matches any sequence of characters that ends with / OR "nothing".
There was a problem hiding this comment.
Yes, that's the idea.
| sb.Append("(.*/|)"); | ||
| i += 3; | ||
| } | ||
| else |
There was a problem hiding this comment.
Do we really need this case?
What about
if (i + 2 < pattern.Length)
{
// Processing .../**/...
sb.Append("(.*/|)");
}
i += 3;If adding three to the index puts the pointer at the end of the pattern we are parsing then we break out of the loop and append .*
There was a problem hiding this comment.
I think this would also work, but I slightly prefer to handle this case explicitly. I think it's going to be easier to understand and maintain going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the path include/exclude logic to allow
**/to match an empty string. This means that**/src/will match the content of thesrcfolder in the root of the repository, while previously it only matchedsrcfolders in subdirectories.