[Draft] Python: Promote cookie injection query from experimental #16893
+491
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
1
to
20
| /** | ||
| * @name Construction of a cookie using user-supplied input. | ||
| * @description Constructing cookies from user input may allow an attacker to perform a Cookie Poisoning attack. | ||
| * @kind path-problem | ||
| * @problem.severity error | ||
| * @precision high | ||
| * @id py/cookie-injection | ||
| * @tags security | ||
| * external/cwe/cwe-614 | ||
| */ | ||
|
|
||
| import python | ||
| import semmle.python.dataflow.new.DataFlow | ||
| import semmle.python.security.dataflow.CookieInjectionQuery | ||
| import CookieInjectionFlow::PathGraph | ||
|
|
||
| from CookieInjectionFlow::PathNode source, CookieInjectionFlow::PathNode sink | ||
| where CookieInjectionFlow::flowPath(source, sink) | ||
| select sink.getNode(), source, sink, "Cookie is constructed from a $@.", source.getNode(), | ||
| "user-supplied input" |
Check warning
Code scanning / CodeQL
Missing security metadata Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/codeql-python-team/issues/792 promoting #6360;
Depends on #16696
Promotes the Cookie Injection query from experimental, finding instances of user input being used to set the name or value of a cookie.