SSA: Add data flow integration layer #16884
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
ssa/dataflow-integration
branch
from
4f346dd
to
6d9de86
Compare
hvitved
force-pushed
the
ssa/dataflow-integration
branch
from
6d9de86
to
ef1fba1
Compare
| @@ -1809,7 +1809,7 @@ | |||
| * Holds if `(bb, i)` contains a write to an iterator that may have been obtained | |||
| * by calling `begin` (or related functions) on the variable `v`. | |||
| */ | |||
| predicate variableWrite(IRBlock bb, int i, SourceVariable v, boolean certain) { | |||
| predicate variableWrite(BasicBlock bb, int i, SourceVariable v, boolean certain) { | |||
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
hvitved
force-pushed
the
ssa/dataflow-integration
branch
2 times, most recently
from
3e93c31
to
59a5b34
Compare
hvitved
force-pushed
the
ssa/dataflow-integration
branch
from
59a5b34
to
4d0d06d
Compare
|
|
||
| bindingset[l1, l2] | ||
| pragma[inline_late] | ||
| private predicate inSameFile0(Location l1, Location l2) { l1.getFile() = l2.getFile() } |
Check warning
Code scanning / CodeQL
Candidate predicate not marked as `nomagic` Warning
hvitved
force-pushed
the
ssa/dataflow-integration
branch
from
4d0d06d
to
e04847a
Compare
hvitved
force-pushed
the
ssa/dataflow-integration
branch
3 times, most recently
from
69608af
to
f8fd8a8
Compare
hvitved
force-pushed
the
ssa/dataflow-integration
branch
from
f8fd8a8
to
b1794cc
Compare
hvitved
force-pushed
the
ssa/dataflow-integration
branch
from
b1794cc
to
35c9233
Compare
hvitved
force-pushed
the
ssa/dataflow-integration
branch
from
35c9233
to
bd303e8
Compare
hvitved
force-pushed
the
ssa/dataflow-integration
branch
from
0e357f7
to
a93296e
Compare
hvitved
force-pushed
the
ssa/dataflow-integration
branch
from
a93296e
to
0319e00
Compare
| @@ -1118,3 +1055,64 @@ | |||
| result = this.getSourceVariable().getEnclosingCallable() | |||
| } | |||
| } | |||
|
|
|||
| private module DataFlowIntegrationInput implements Impl::DataFlowIntegrationInputSig { | |||
| private import csharp as Cs | |||
Check warning
Code scanning / CodeQL
Names only differing by case Warning
hvitved
force-pushed
the
ssa/dataflow-integration
branch
from
ea2d316
to
13c109c
Compare
hvitved
force-pushed
the
ssa/dataflow-integration
branch
from
8a8e8fc
to
76751a5
Compare
Comment on lines
+1325
to
+1328
| e = getARead(_) | ||
| or | ||
| DfInput::ssaDefAssigns(_, e) and | ||
| isPost = false |
Check warning
Code scanning / CodeQL
Var only used in one side of disjunct. Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.