CWE-830 Polyfill.io #16882
Closed
CWE-830 Polyfill.io #16882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
reviewed
Jul 1, 2024
There was a problem hiding this comment.
Thanks, but some more work is needed here.
Let me know if you want me to do any of the below.
I took at look at some compromised websites and polyfill.io is mainly used like:
<script src=https://cdn.polyfill.io/v2/polyfill.min.js></script>Can you add support for that pattern, and add test-cases for both patterns.
Additionally, the format-check is failing, you can use codeql query format -i <path-to-ql-file> to run the autoformatter.
|
I've raised an alernative PR, which abstracts an existing library out from an existing CWE-830 query: #16886 |
|
Hmm. See my comment on the other PR. It seems the issue is no longer relevant, as the domain no longer exists. |
|
Closing as @aegilops' PR is a lot more comprehensive + Namecheap has shut down the domain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a simple
Javascriptqueryjs/cwe-830/polyfill-ioto alert on instances where users import frompolyfill.io, a compromised domain utilized in Supply Chain Attacks: https://sansec.io/research/polyfill-supply-chain-attack