Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ SimpleRangeAnalysis: remove float bounds #16862

Closed
wants to merge 4 commits into from
Closed

C++ SimpleRangeAnalysis: remove float bounds #16862

wants to merge 4 commits into from

Commits on Jul 5, 2024

  1. SimpleRangeAnalysis: Remove ±Inf typeBounds for FloatingPointType 

    If this doesn't break any tests, then this will simplify the rewrite of all SimpleRangeAnalysis floats to BigInt.
    @d10c
    d10c committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e572f3b View commit details
    Browse the repository at this point in the history

  2. Update tests 

    We are mostly losing precision due to excluding float operations from range analysis.
    @d10c
    d10c committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    252bb9e View commit details
    Browse the repository at this point in the history

  3. ArithmeticUncontrolled: float exprs are barriers. 

    This leads to two regressions, but this should be OK if we decide to drop float support from SimpleRangeAnalysis

Keeping high query precision to keep it in code scanning.
    @d10c
    d10c committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6589fc5 View commit details
    Browse the repository at this point in the history

  4. Library change note

    @d10c
    d10c committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b123901 View commit details
    Browse the repository at this point in the history