Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Convert chi echo and elazarl sources to MaD #16856

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jun 27, 2024

Convert sources from Chi, Echo and Elazarl to MaD.

I don't believe it needs a change note.

@owen-mc owen-mc requested a review from egregius313 June 27, 2024 06:36
@github-actions github-actions bot added the Go label Jun 27, 2024
@owen-mc owen-mc force-pushed the go/mad-sources-chi-echo-elazarl branch from 18061d1 to a527e72 Compare June 27, 2024 09:27
Copy link
Contributor

github-actions bot commented Jun 27, 2024

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

go

Generated file changes for go

  • Changes to framework-coverage-go.rst:
-    `Echo <https://echo.labstack.com/>`_,``github.com/labstack/echo*``,,2,
+    `Echo <https://echo.labstack.com/>`_,``github.com/labstack/echo*``,12,2,
-    `goproxy <https://github.com/elazarl/goproxy>`_,``github.com/elazarl/goproxy*``,,2,
+    `goproxy <https://github.com/elazarl/goproxy>`_,``github.com/elazarl/goproxy*``,2,2,
+    Others,``github.com/go-chi/chi``,3,,
-    Totals,,83,884,24
+    Totals,,100,884,24
  • Changes to framework-coverage-go.csv:
- github.com/elazarl/goproxy,,,2,,,,2,
+ github.com/elazarl/goproxy,,2,2,,,2,2,
+ github.com/go-chi/chi,,3,,,,3,,
- github.com/labstack/echo,,,2,,,,2,
+ github.com/labstack/echo,,12,2,,,12,2,

@owen-mc owen-mc force-pushed the go/mad-sources-chi-echo-elazarl branch from a527e72 to 39e19d8 Compare July 2, 2024 08:38
@owen-mc owen-mc marked this pull request as ready for review July 2, 2024 09:33
@owen-mc owen-mc requested a review from a team as a code owner July 2, 2024 09:33
@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant