Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: allow installer script to install into multiple directories, in parallel #16846

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

redsun82
Copy link
Contributor

No description provided.

@redsun82 redsun82 requested a review from a team as a code owner June 26, 2024 14:55
@redsun82 redsun82 requested a review from criemen June 26, 2024 14:55
@redsun82 redsun82 marked this pull request as draft June 27, 2024 07:50
@redsun82 redsun82 changed the title Bazel: allow installer script to install into multiple directories Bazel: allow installer script to install into multiple directories, in parallel Jun 27, 2024
@redsun82 redsun82 marked this pull request as ready for review June 27, 2024 08:10
@redsun82
Copy link
Contributor Author

I might have overengineered it, but I think we could shave off several seconds in the final install steps for full dists if we employ this.

@criemen
Copy link
Collaborator

criemen commented Jun 27, 2024

I might have overengineered it, but I think we could shave off several seconds in the final install steps for full dists if we employ this.

You think so? I'd have guessed that ripunzip already employs parallelity, so there's not so much to be gained by calling it multiple times in parallel. I guess we can see if copying the extractor files could be sped up like this. I'll put this onto my review queue, but at lower priority. I guess this'd need somewhat significant changes to how we build pack groups to be used for single-target intree dists like target/intree/codeql.

@redsun82
Copy link
Contributor Author

It might be that most of the gain would rather come from avoiding the multiple bazel run overhead, rather than using parallelism. We can always test that out and remove the code for parallel runs if it doesn't really matter. In any case, yes, this can definitely wait.

@criemen
Copy link
Collaborator

criemen commented Jun 27, 2024

Ah, a single intree-dist is currently already modelled by a single bazel run, it's just split dists that invoke bazel run multiple times (once for nolang, once for every extractor requested)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants