Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Replace the MaD Object.clone() models with a non-aliasing value step. #16835

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

aschackmull
Copy link
Contributor

Switching data flow stage 3 to path-insensitive type pruning flow highlighted that the MaD clone models were providing false type information in the sense that they claim to be able to store into Element, MapKey, and MapValue for any type. This is misleading to path-insensitive type pruning.
With the introduction of support for non-aliasing value steps in the data flow library, we can model clone steps as value steps instead without accidental back-propagation of side-effects.
Local + MRVA top 100 checking showed only small changes in tuple counts, although a number of FPs were fixed on apache/hadoop for one query.

@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label Jun 25, 2024
@aschackmull aschackmull requested a review from a team as a code owner June 25, 2024 13:52
@github-actions github-actions bot added the Java label Jun 25, 2024
Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java Standard Library,``java.*``,10,4267,255,95,,9,,,26
+    Java Standard Library,``java.*``,10,4264,255,95,,9,,,26
-    Totals,,310,25130,2590,359,16,128,33,1,409
+    Totals,,310,25127,2590,359,16,128,33,1,409
  • Changes to framework-coverage-java.csv:
- java.lang,38,3,759,,13,,,,,,1,,,,,,,,,,,,8,,,,11,,,4,,,1,,,,,,,,,,,,,,,3,,,681,78
+ java.lang,38,3,756,,13,,,,,,1,,,,,,,,,,,,8,,,,11,,,4,,,1,,,,,,,,,,,,,,,3,,,681,75

owen-mc
owen-mc previously approved these changes Jun 25, 2024
@owen-mc
Copy link
Contributor

owen-mc commented Jun 25, 2024

Most of the test failures are model numbering changes, but not all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants