Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Go: CORS Bypass due to incorrect checks #16813

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Jul 3, 2024

  1. WIP: Go: CORS Bypass due to incorrect checks

    Most Go frameworks provide a function call where-in you can pass a handler for testing origins and performing CORS checks.
    These functions typically check for the supllied origin in a list of valid origins. This behaviour is mostly fine but can lead to issues when done incorrectly. for example, consider the code snippets below
    
    https://github.com/zeromicro/go-zero/blob/5c9fae7e6258fd66d026793e7cb03ba9955e3dee/rest/internal/cors/handlers.go#L79-L91
    
    https://github.com/play-with-docker/play-with-docker/blob/7188d83f867cbc201aef4b0597ac5f868c1971f3/handlers/bootstrap.go#L71-L80
    
    In both these cases, the checks are implemented incorrectly and can lead to a CORS bypass resulting in CVE-2023-28109 and CVE-2024-27302.
    
    This PR aims to add a query, and its corresponding qhelp and tests for detecting the same vulnerability.
    
    The databases to verify the same can be downloaded from
    
    ```
    https://file.io/OQX8Q3H3hMd4
    https://filetransfer.io/data-package/wAfSEvZu#link
    ```
    porcupineyhairs committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    71fd955 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    5b84c0c View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Configuration menu
    Copy the full SHA
    883fd00 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Configuration menu
    Copy the full SHA
    b2ade75 View commit details
    Browse the repository at this point in the history