Skip to content

Commit

Permalink
Avoid use of plain 'None' in tests
Browse files Browse the repository at this point in the history
For some reason the parser resolves the ambiguity between None as a PathPat or IdentPat
differently on the Action runners vs local machine.
  • Loading branch information
aibaars committed Sep 13, 2024
1 parent e682298 commit d73d90d
Show file tree
Hide file tree
Showing 33 changed files with 106 additions and 111 deletions.
30 changes: 15 additions & 15 deletions rust/ql/.generated.list

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions rust/ql/lib/codeql/rust/elements/BoxPat.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions rust/ql/lib/codeql/rust/elements/IdentPat.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/ql/lib/codeql/rust/elements/MatchArm.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/ql/lib/codeql/rust/elements/MatchExpr.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions rust/ql/lib/codeql/rust/elements/MissingPat.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/ql/lib/codeql/rust/elements/OrPat.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/ql/lib/codeql/rust/elements/RefPat.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/ql/lib/codeql/rust/generated/BoxPat.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions rust/ql/lib/codeql/rust/generated/IdentPat.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/ql/lib/codeql/rust/generated/MatchArm.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/ql/lib/codeql/rust/generated/MatchExpr.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions rust/ql/lib/codeql/rust/generated/MissingPat.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/ql/lib/codeql/rust/generated/OrPat.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 14 additions & 15 deletions rust/ql/lib/codeql/rust/generated/Raw.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/ql/lib/codeql/rust/generated/RefPat.qll

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions rust/ql/test/extractor-tests/generated/.generated_tests.list

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/ql/test/extractor-tests/generated/BoxPat/BoxPat.expected
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
| gen_box_pat.rs:6:9:6:19 | BoxPat | getInner: | gen_box_pat.rs:6:13:6:19 | TupleStructPat |
| gen_box_pat.rs:7:9:7:16 | BoxPat | getInner: | gen_box_pat.rs:7:13:7:16 | PathPat |
| gen_box_pat.rs:6:9:6:27 | BoxPat | getInner: | gen_box_pat.rs:6:13:6:27 | TupleStructPat |
| gen_box_pat.rs:7:9:7:24 | BoxPat | getInner: | gen_box_pat.rs:7:13:7:24 | PathPat |
4 changes: 2 additions & 2 deletions rust/ql/test/extractor-tests/generated/BoxPat/gen_box_pat.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
| gen_ident_pat.rs:6:14:6:14 | IdentPat | getBindingId: | y | hasSubpat: | no |
| gen_ident_pat.rs:10:9:10:17 | IdentPat | getBindingId: | y | hasSubpat: | yes |
| gen_ident_pat.rs:6:22:6:22 | IdentPat | getBindingId: | y | hasSubpat: | no |
| gen_ident_pat.rs:10:9:10:25 | IdentPat | getBindingId: | y | hasSubpat: | yes |
Original file line number Diff line number Diff line change
@@ -1 +1 @@
| gen_ident_pat.rs:10:9:10:17 | IdentPat | gen_ident_pat.rs:10:11:10:17 | TupleStructPat |
| gen_ident_pat.rs:10:9:10:25 | IdentPat | gen_ident_pat.rs:10:11:10:25 | TupleStructPat |

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
| gen_match_arm.rs:6:9:6:15 | MatchArm | getPat: | gen_match_arm.rs:6:9:6:15 | TupleStructPat | hasGuard: | no | getExpr: | gen_match_arm.rs:6:20:6:20 | PathExpr |
| gen_match_arm.rs:7:9:7:12 | MatchArm | getPat: | gen_match_arm.rs:7:9:7:12 | PathPat | hasGuard: | no | getExpr: | gen_match_arm.rs:7:17:7:17 | Literal |
| gen_match_arm.rs:6:9:6:23 | MatchArm | getPat: | gen_match_arm.rs:6:9:6:23 | TupleStructPat | hasGuard: | no | getExpr: | gen_match_arm.rs:6:28:6:28 | PathExpr |
| gen_match_arm.rs:7:9:7:20 | MatchArm | getPat: | gen_match_arm.rs:7:9:7:20 | PathPat | hasGuard: | no | getExpr: | gen_match_arm.rs:7:25:7:25 | Literal |
| gen_match_arm.rs:10:9:10:15 | MatchArm | getPat: | gen_match_arm.rs:10:9:10:15 | TupleStructPat | hasGuard: | yes | getExpr: | gen_match_arm.rs:10:30:10:34 | BinExpr |
| gen_match_arm.rs:11:9:11:9 | MatchArm | getPat: | gen_match_arm.rs:11:9:11:9 | WildcardPat | hasGuard: | no | getExpr: | gen_match_arm.rs:11:14:11:14 | Literal |

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
| gen_match_expr.rs:5:5:8:5 | MatchExpr | 0 | gen_match_expr.rs:6:9:6:15 | MatchArm |
| gen_match_expr.rs:5:5:8:5 | MatchExpr | 1 | gen_match_expr.rs:7:9:7:12 | MatchArm |
| gen_match_expr.rs:5:5:8:5 | MatchExpr | 0 | gen_match_expr.rs:6:9:6:23 | MatchArm |
| gen_match_expr.rs:5:5:8:5 | MatchExpr | 1 | gen_match_expr.rs:7:9:7:20 | MatchArm |
| gen_match_expr.rs:9:5:12:5 | MatchExpr | 0 | gen_match_expr.rs:10:9:10:15 | MatchArm |
| gen_match_expr.rs:9:5:12:5 | MatchExpr | 1 | gen_match_expr.rs:11:9:11:9 | MatchArm |

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
| gen_or_pat.rs:6:9:6:22 | OrPat | getNumberOfArgs: | 2 |
| gen_or_pat.rs:6:9:6:38 | OrPat | getNumberOfArgs: | 2 |
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
| gen_or_pat.rs:6:9:6:22 | OrPat | 0 | gen_or_pat.rs:6:9:6:15 | TupleStructPat |
| gen_or_pat.rs:6:9:6:22 | OrPat | 1 | gen_or_pat.rs:6:19:6:22 | PathPat |
| gen_or_pat.rs:6:9:6:38 | OrPat | 0 | gen_or_pat.rs:6:9:6:23 | TupleStructPat |
| gen_or_pat.rs:6:9:6:38 | OrPat | 1 | gen_or_pat.rs:6:27:6:38 | PathPat |
2 changes: 1 addition & 1 deletion rust/ql/test/extractor-tests/generated/OrPat/gen_or_pat.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/ql/test/extractor-tests/generated/RefPat/RefPat.expected
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
| gen_ref_pat.rs:6:9:6:20 | RefPat | getPat: | gen_ref_pat.rs:6:14:6:20 | TupleStructPat | isMut: | yes |
| gen_ref_pat.rs:7:9:7:13 | RefPat | getPat: | gen_ref_pat.rs:7:10:7:13 | PathPat | isMut: | no |
| gen_ref_pat.rs:6:9:6:28 | RefPat | getPat: | gen_ref_pat.rs:6:14:6:28 | TupleStructPat | isMut: | yes |
| gen_ref_pat.rs:7:9:7:21 | RefPat | getPat: | gen_ref_pat.rs:7:10:7:21 | PathPat | isMut: | no |
Loading

0 comments on commit d73d90d

Please sign in to comment.