Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: github actions cleanup #149

Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore: github actions cleanup #149

merged 1 commit into from
Nov 20, 2024

Conversation

jmeridth
Copy link
Member

Pull Request

Proposed Changes

  • switch to umutable actions on ones that allow it (closes 8 security warnings)
  • solve actionlint issues
    • double quote variable to prevent globbing and word splitting

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance or breaking

- [x] switch to umutable actions on ones that allow it (closes 8 security warnings)
- [x] solve actionlint issues
  - [x] double quote variable to prevent globbing and word splitting

Signed-off-by: jmeridth <[email protected]>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • .github/workflows/stale.yaml: Evaluated as low risk

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@jmeridth jmeridth merged commit 022f712 into main Nov 20, 2024
29 checks passed
@jmeridth jmeridth deleted the jm_actions_cleanup branch November 20, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant