only use mkl dense gemm when all value pointers are valid #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
added
1:ST:ready-for-review
ginkgo-bot
added
type:matrix-format
yhmtsai
added
the
1:ST:no-changelog-entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We notice an page fault error from accessing nullptr in mkl dense gemm.
The issue happens when we pass empty matrix (nullptr) and only with single right hand side, but the routine seems to still access the pointer.
It only happens with rolling version of intel runtime library, which starts throwing error on page fault I guess, not long-term-support channel with icpx/oneMKL 2023.1.0 and 2025.0.4.
We simply avoid this issue by only calling mkl gemm when all data pointer are vaild.