-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bfloat16 #1709
Draft
yhmtsai
wants to merge
48
commits into
develop
Choose a base branch
from
bfloat16
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marcel Koch <[email protected]>
stack size can not be determined statically issue some tests are failed
sqrt need to be global namespace to live with hip sqrt
It seems to use complex version even using half only
next_precision<double> = float not half
create_empty for its own type
sycl::half has different rule in conv and full operator after 5.7
ginkgo-bot
added
reg:build
This is related to the build system.
reg:testing
This is related to testing.
reg:ci-cd
This is related to the continuous integration system.
reg:benchmarking
This is related to benchmarking.
type:solver
This is related to the solvers
type:preconditioner
This is related to the preconditioners
type:matrix-format
This is related to the Matrix formats
type:factorization
This is related to the Factorizations
type:reordering
This is related to the matrix(LinOp) reordering
reg:helper-scripts
This issue/PR is related to the helper scripts mainly concerned with development of Ginkgo.
type:multigrid
This is related to multigrid
type:stopping-criteria
This is related to the stopping criteria
mod:all
This touches all Ginkgo modules.
labels
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1:ST:do-not-merge
Please do not merge PR this yet.
mod:all
This touches all Ginkgo modules.
reg:benchmarking
This is related to benchmarking.
reg:build
This is related to the build system.
reg:ci-cd
This is related to the continuous integration system.
reg:helper-scripts
This issue/PR is related to the helper scripts mainly concerned with development of Ginkgo.
reg:testing
This is related to testing.
type:factorization
This is related to the Factorizations
type:matrix-format
This is related to the Matrix formats
type:multigrid
This is related to multigrid
type:preconditioner
This is related to the preconditioners
type:reordering
This is related to the matrix(LinOp) reordering
type:solver
This is related to the solvers
type:stopping-criteria
This is related to the stopping criteria
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to make it more visible, ginkgo can also support bfloat16 like half in the future.
Please do not review this pr, it will follow half structure after merging half