-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the majority of jobs to the full pipeline #1694
Conversation
e218c76
to
bde4502
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still prefer the original grouping strategy
The configuration under same compiler version are slightly different, so grouping them together might be easier to configure or distinguish them.
I mean grouping by device+compiler. |
I think it would make sense to group jobs properly to be able to navigate and access them easily. The main groups could be |
@yhmtsai that grouping is still there, just now it's under the full pipeline. I don't think it's reasonable to have our current 'quick' pipeline run with 15+ jobs, while our 'full' pipeline has ~10 jobs. The quick pipeline is always run, even if the PR is still a bit under development. The 15+ jobs are not needed during that phase, so the CI is just clogged with meaningless tests. |
@pratikvn That looks like a nice feature. Sidenote: I would not count |
@MarcelKoch I do not mean the quick/full changes in this pr. original:
the current change
|
Ah, I see. I understand your issue, perhaps the file restructuring would fit better in a later PR, e.g. by naming those test just |
bde4502
to
de32575
Compare
Quality Gate passedIssues Measures |
This merge the majority of the gitlab jobs to the full pipeline. Related PR: ginkgo-project#1694
This PR moves the majority of the gitlab jobs to the full pipeline.
IMO our CI could use a more thourough restructuring, since the job properties are very random, but that should be done later.