Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factory config #1392

Merged
merged 25 commits into from
May 27, 2024
Merged

Factory config #1392

merged 25 commits into from
May 27, 2024

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Aug 17, 2023

As we discussed, we only focus on the LinOpFactory generation first.
Also, the dispatch only supports type now.
The public interface only provides LinOpFactory, not concrete type generation if we do not want the function with executor arg in Solver.

@yhmtsai yhmtsai self-assigned this Aug 17, 2023
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:testing This is related to testing. mod:core This is related to the core module. type:solver This is related to the solvers labels Aug 17, 2023
@MarcelKoch
Copy link
Member

An alternative implementation based on std::variant can be found here: property_tree...file-config-testground

This also doesn't use macros to set the factory parameters at the last step of the parsing. It also allows setting value types or index types as template parameters to parse.

@yhmtsai
Copy link
Member Author

yhmtsai commented Aug 18, 2023

the macro for setting will be reused serveral times, so I put it in macro

@yhmtsai yhmtsai mentioned this pull request Aug 21, 2023
Merged
1 task
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 47 Code Smells

62.6% 62.6% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

MarcelKoch
MarcelKoch reviewed Aug 24, 2023
View reviewed changes
core/config/config.hpp Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 50 Code Smells

59.1% 59.1% Coverage
1.0% 1.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@yhmtsai yhmtsai added the 1:ST:ready-for-review This PR is ready for review label Oct 12, 2023
@github-actions github-actions bot deleted a comment from ginkgo-bot Nov 27, 2023
@github-actions GitHub Actions
Copy link

Error: The following files need to be formatted:

core/config/config.cpp
core/config/config.hpp
core/config/dispatch.hpp
core/config/property_tree.cpp
core/config/stop_config.cpp
core/test/config/config.cpp
core/test/config/property_tree.cpp
core/test/config/registry.cpp
include/ginkgo/core/config/config.hpp
include/ginkgo/core/config/registry.hpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

@yhmtsai yhmtsai force-pushed the factory_config branch 2 times, most recently from d55042e to ef7430c Compare December 1, 2023 09:16
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 46 Code Smells

62.0% 62.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

yhmtsai and others added 24 commits May 27, 2024 11:19
@yhmtsai
change the order and put it into protected
70f098e
@yhmtsai
add type descripitor
284afed
@yhmtsai
add the general type dispatch
9d11041
@yhmtsai
use property_tree as config type
c272d6b
@yhmtsai
update the usage of property tree
6ebce2e
@yhmtsai
move the function into internal not protected
bcc54a1
@yhmtsai
update stop config
1f9386c
@yhmtsai
add registry test
0c25063
@yhmtsai
throw gko::Error
2941cb2
@yhmtsai
add get_value
d52036d
@yhmtsai
update usage of property tree
8f66c85
@yhmtsai
use deferred_factory_parameter (generate param)
88a41fa
@yhmtsai
adapt with the explicit deferred type
557c6d6
@yhmtsai
adapt the corresponding changes
bf30b5d
@yhmtsai
reduce the macro usage
a2cc99c
@yhmtsai
export less function in public and move def. to cpp
b26951c
@yhmtsai
move the def to source of registry
3db9203
@yhmtsai
adapt the changes
da4a31b
@yhmtsai
add type_descriptor class
92bf10a
@yhmtsai @MarcelKoch
split file, update doc and name, couple type_list and str
4535b58 
Co-authored-by: Marcel Koch <[email protected]>
@yhmtsai @MarcelKoch
combine map together
3b6ff47 
Co-authored-by: Marcel Koch <[email protected]>
@yhmtsai @MarcelKoch
rename, always contain gko map, move getter into protect
69de11a 
Co-authored-by: Marcel Koch <[email protected]>
@yhmtsai @MarcelKoch
add general intro, use snake_case, and fixed-width notation
5412de5 
Co-authored-by: Marcel Koch <[email protected]>
@yhmtsai @upsj @MarcelKoch
update documentation, rename, complex number and rm stop::, index_type
2629167 
Co-authored-by: Thomas Grützmacher <[email protected]>
Co-authored-by: Tobias Ribizel <[email protected]>
Co-authored-by: Marcel Koch <[email protected]>
@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels May 27, 2024
@yhmtsai yhmtsai merged commit eeaa7aa into develop May 27, 2024
13 of 15 checks passed
@yhmtsai yhmtsai deleted the factory_config branch May 27, 2024 14:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
28 New issues
0 Accepted issues

Measures
0 Security Hotspots
62.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelKoch MarcelKoch MarcelKoch approved these changes

@thoasm thoasm thoasm approved these changes

@upsj upsj Awaiting requested review from upsj

Assignees

@yhmtsai yhmtsai

Labels
1:ST:ready-to-merge This PR is ready to merge. mod:core This is related to the core module. reg:build This is related to the build system. reg:testing This is related to testing. type:solver This is related to the solvers
Projects
None yet
Milestone
Ginkgo 1.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yhmtsai @MarcelKoch @upsj @thoasm @ginkgo-bot