feat(GiniHealthSDK): Refactor integration for easy use #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gration-health-sdk
… trust markers entry point
…ror" This reverts commit bce7830.
…w screen because now we handle flow and we only push Payment Review screen
…gration-health-sdk
zladzeyka
requested changes
Nov 18, 2024
There was a problem hiding this comment.
I was thinking about 1 more improvement
we should move the startPaymentFlow(documentId: nil, paymentInfo: obtainPaymentInfo(), navigationController: navigationController, trackingDelegate: self)
inside GiniHealth and operate with paymentComponentsController under the hood if it's possible
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Show resolved
Hide resolved
…applicable for the document invoices IPC-430
…hare-with-onboarding-screen
…352-health-documentation-update
…352-health-documentation-update
…352-health-documentation-update
…fter payment info
…ng-screen feat(GiniHealthSDK): Replace Share Onboarding screen
There was a problem hiding this comment.
@razvancapra Can you please check my comments and clarification questions? And as well, Nadya left some small suggestions.
Thank you!
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDKExample/GiniHealthSDKExample/InvoicesList/InvoicesListViewModel.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDKExample/GiniHealthSDKExample/OrdersList/OrderListViewModel.swift
Outdated
Show resolved
Hide resolved
…cumentation-update
…ontainer view IPC-432
…ller devices IPC-434
feat(GiniHealthSDK): Health documentation update
|
ValentinaIancu-Gini
approved these changes
Nov 22, 2024
razvancapra
changed the base branch from
IPC-347-handle-paid-adjusted-status
to
Payment-Component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.