PP-138 alternative token source #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zladzeyka
requested changes
Oct 29, 2024
BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/GiniBankNetworkingScreenApiCoordinator.swift
Outdated
Show resolved
Hide resolved
igor-gini
force-pushed
the
PP-138-alternative-token-source
branch
from
595ece2 to
2ba39aa
Compare
zladzeyka
requested changes
Nov 6, 2024
BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/GiniBankNetworkingScreenApiCoordinator.swift
Outdated
Show resolved
Hide resolved
zladzeyka
requested changes
Nov 8, 2024
BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift
Outdated
Show resolved
Hide resolved
BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/Networking/GiniBank+Networking.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@igor-gini thank you for the updates. I left some small comments almost for tests.
BankSDK/GiniBankSDK/Tests/GiniBankSDKTests/NetworkingScreenApiCoordinatorTests.swift
Show resolved
Hide resolved
BankSDK/GiniBankSDK/Tests/GiniBankSDKTests/NetworkingScreenApiCoordinatorTests.swift
Outdated
Show resolved
Hide resolved
BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift
Show resolved
Hide resolved
|
ValentinaIancu-Gini
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
@igor-gini Thank you for the update! I think we are good to go with this pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.