Pp 623 implement full screen skonto details snapshot from the invoice #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils` object PP-623
…tion call and error handling into separate private methods - Extracted the `extractions` call into a new private method `startExtraction` - Moved error handling into a new private method `handleError` - Left the completion handler outside of the `handleError` method to maintain separation of concerns - Improved code modularity and readability PP-623
…mentServiceProtocol` PP-623
…CaptureNetworkService` public protocol PP-623
…wViewController` - `didTapInvoicePreview` added - cleanup in `SkontoVieModel` to follow easily the code PP-623
…Id: String, number: Int, sizeVariant: Document.Layout.SizeVariant)` PP-623
…: .zero, size: .zero)` PP-623
…formation into `DocumentPagesViewController` PP-623
…f possible PP-623
- Boolean literals should not be redundant PP-623
mrkulik
requested changes
Aug 14, 2024
There was a problem hiding this comment.
@ValentinaIancu-Gini Great job! I left some suggestions, please let me know your thoughts!
On iPad landscape vertical scroll is not working (Image is displayed outside the frame at start and we can't scroll to the bottom/top), with horizontal all ok. Based on Figma, in landscape mode document should be displayed in full height:
https://github.com/user-attachments/assets/8fe0caca-5deb-42e1-b858-7ddde9c61629
After zooming, vertical scroll works strange, can't scroll to see image details:
https://github.com/user-attachments/assets/75320583-2c87-424d-b728-e5b82bf010ad
.../GiniBankSDK/Sources/GiniBankSDK/Core/Skonto/DocumentPages/DocumentPagesViewController.swift
Outdated
Show resolved
Hide resolved
.../GiniBankSDK/Sources/GiniBankSDK/Core/Skonto/DocumentPages/DocumentPagesViewController.swift
Outdated
Show resolved
Hide resolved
.../GiniBankSDK/Sources/GiniBankSDK/Core/Skonto/DocumentPages/DocumentPagesViewController.swift
Outdated
Show resolved
Hide resolved
.../GiniBankSDK/Sources/GiniBankSDK/Core/Skonto/DocumentPages/DocumentPagesViewController.swift
Outdated
Show resolved
Hide resolved
.../GiniBankSDK/Sources/GiniBankSDK/Core/Skonto/DocumentPages/DocumentPagesViewController.swift
Outdated
Show resolved
Hide resolved
.../GiniBankSDK/Sources/GiniBankSDK/Core/Skonto/DocumentPages/DocumentPagesViewController.swift
Outdated
Show resolved
Hide resolved
.../GiniBankSDK/Sources/GiniBankSDK/Core/Skonto/DocumentPages/DocumentPagesViewController.swift
Outdated
Show resolved
Hide resolved
.../GiniBankSDK/Sources/GiniBankSDK/Core/Skonto/DocumentPages/DocumentPagesViewController.swift
Show resolved
Hide resolved
.../GiniBankSDK/Sources/GiniBankSDK/Core/Skonto/DocumentPages/DocumentPagesViewController.swift
Outdated
Show resolved
Hide resolved
.../GiniBankSDK/Sources/GiniBankSDK/Core/Skonto/DocumentPages/DocumentPagesViewController.swift
Outdated
Show resolved
Hide resolved
…parameters PP-623
… to retrieve pages for a document PP-623
…` and `large` cases and remove `SizeVariant` from Layout PP-623
…etching each page of the document PP-623
…loading indicator PP-623
… `scrollView.maximumZoomScale` PP-623
…n-Skonto-details-snapshot-from-the-invoice # Conflicts: # BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/Skonto/SkontoCoordinator.swift # BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/Skonto/SkontoViewModel.swift # BankSDK/GiniBankSDK/Sources/GiniBankSDK/Resources/GiniImages.swift
|
mrkulik
approved these changes
Aug 19, 2024
ValentinaIancu-Gini
merged commit 038951e
into
PP-Skonto-version-2.0
9 of 23 checks passed
ValentinaIancu-Gini
deleted the
PP-623-Implement-Full-Screen-Skonto-details-snapshot-from-the-invoice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user taps that document preview view from the main screen(Skonto screen), the app should display the image of the invoice with the Skonto details highlighted in full-screen mode.