PP 284 implementation of outage messages #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- corresponding strings where added - test 503 error -> `maintenance` type - added the corresponding asset for the visual of this new error PP-284
- corresponding strings where added both en and de - test 500 error -> `outage` type PP-284
…Error` and `unexpectedError` - group texts in localization files PP-284
…tedError` english version PP-284
- the "no internet connection" error wan't handled until now PP-284
…iniError - display generic error messages in case of `noResponse` error PP-284
zladzeyka
approved these changes
Feb 20, 2024
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Error/ErrorType.swift
Outdated
Show resolved
Hide resolved
zladzeyka
reviewed
Feb 20, 2024
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Error/ErrorType.swift
Outdated
Show resolved
Hide resolved
…error type PP-284
ValentinaIancu-Gini
force-pushed
the
PP-284-Implementation-of-outage-messages
branch
from
60a6ef6 to
b224651
Compare
…ror to `ErrorType.unexpected` PP-284
|
@zladzeyka please check again. I fixed the test that was crashing. 🤦 |
zladzeyka
reviewed
Feb 28, 2024
|
@zladzeyka I did the refactoring, fixed one test, and added one more. When you have time please check it. |
zladzeyka
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Looks good @ValentinaIancu-Gini,
please find the tiny suggestion about a missing whitespace
...APILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/SessionManager.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are handling separately some specific errors: