Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bsdk 27 anonymous user not logged in again after each ios gini bank api library launch #446

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Bsdk 27 anonymous user not logged in again after each ios gini bank api library launch #446

merged 3 commits into from
Feb 12, 2024

Conversation

ValentinaIancu-Gini
Copy link
Contributor

  • Fixes anonymous user to log in again after each GiniBankApiLibrary launch
  • cleanup code

@ValentinaIancu-Gini
fix(GiniBankAPILibrary): Remove code that removes the current user wh…
5f01327 
…ile handling the `unauthorized` error

- no need to remove the user in `handleError` method

BSDK-27
@ValentinaIancu-Gini
fix(GiniBankAPILibrary): Fix anonymous user to be logged in again aft…
ba9356f 
…er each GiniBankAPILibrary launch

- handle locally auth errors for login flow
- persist `clientAccessToken` and `userAccessToken` in `SessionManager` for current app session

BSDK-27
@ValentinaIancu-Gini ValentinaIancu-Gini self-assigned this Jan 19, 2024
@ValentinaIancu-Gini
Copy link
Contributor Author

@a-szotyori @zladzeyka I wasn't sure if I needed to add
try keychainStore.remove(service: .auth, key: .clientAccessToken) in removeStoredCredentials method from GiniBankAPI class. I thought that was not necessary since clientAccessToken is the first token that we need to create a new user.
What do you think?

@ValentinaIancu-Gini ValentinaIancu-Gini force-pushed the BSDK-27-Anonymous-user-not-logged-in-again-after-each-iOS-Gini-Bank-API-Library-launch branch from 8449d9b to 1bbf6af Compare January 22, 2024 15:53
@ValentinaIancu-Gini
refactor(GiniBankAPILibrary): Clean up code
2b86cf5 
- rename properties
- indent code
- remove `expirationDate` from `KeychainKey` enum

BSDK-27
@ValentinaIancu-Gini ValentinaIancu-Gini force-pushed the BSDK-27-Anonymous-user-not-logged-in-again-after-each-iOS-Gini-Bank-API-Library-launch branch from 1bbf6af to 2b86cf5 Compare January 22, 2024 16:02
zladzeyka
zladzeyka approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@zladzeyka zladzeyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊 Great success!

@ValentinaIancu-Gini ValentinaIancu-Gini merged commit ac78779 into main Feb 12, 2024
22 of 26 checks passed
@ValentinaIancu-Gini ValentinaIancu-Gini deleted the BSDK-27-Anonymous-user-not-logged-in-again-after-each-iOS-Gini-Bank-API-Library-launch branch February 12, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zladzeyka zladzeyka zladzeyka approved these changes

@a-szotyori a-szotyori Awaiting requested review from a-szotyori

Assignees

@ValentinaIancu-Gini ValentinaIancu-Gini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValentinaIancu-Gini @zladzeyka