-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pia 4522 UI for iban detection on device iOS #427
Merged
zladzeyka
merged 46 commits into
main
from
PIA-4522-UI-for-IBAN-detection-on-device-iOS
Oct 23, 2023
Merged
Pia 4522 UI for iban detection on device iOS #427
zladzeyka
merged 46 commits into
main
from
PIA-4522-UI-for-IBAN-detection-on-device-iOS
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Controller PIA-4356
… a method for detecting IBAN, remove public access from override methods PIA-4356
… detection PIA-4356
…on, handle output adding PIA-4356
Fix compile errors in Camera with XCode 14.2 PIA-4356
PIA-4356
…, fix lint issue PIA-4356
…mplemented `IBANValidator` PIA-4356
…x lint issues, rename `extractIBANS` -> IBANRecogniser PIA-4356
… add test for IBAN prioritisation PIA-4356
…upported - the IBAN detection will work on devices that have the minimum version iOS 13 but the SDK should be supported also for devices with iOS 12 PIA-4522
…e` loading indicator style on Review screen PIA-4522
…ting with iOS 13.0 PIA-4522
….com:gini/gini-mobile-ios into PIA-4522-UI-for-IBAN-detection-on-device-iOS
ValentinaIancu-Gini
changed the base branch from
PIA-4356_on_device_iban_detection
to
main
October 18, 2023 11:56
# Conflicts: # BankSDK/GiniBankSDKExample/GiniBankSDKExample.xcodeproj/project.pbxproj # CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Camera/CameraPreviewViewController.swift
- fix the detection of the IBAN when the flow is starting from PhotoPayment button PIA-4522
…in the same screen PIA-4522
…detected qr is invalid and no IBAN in the screen PIA-4522
….com:gini/gini-mobile-ios into PIA-4522-UI-for-IBAN-detection-on-device-iOS
…alization, IBAN format to display, position of the IBAN detection on iPad in portrait orientation - cleanup code PIA-4522
…ring and UIActivityIndicatorView, rename localization strings - rename: IBANs -> ibans; setLargeStyle -> applyLargeStyle; setZoomForSmallText -> applyZoomForSmallText - code cleanup: remove unused code, extract Constants PIA-4522
zladzeyka
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We reviewed together with @ValentinaIancu-Gini
…top of iban detection view PIA-4522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UI for IBAN detection
PIA-4522