Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pia 4522 UI for iban detection on device iOS #427

Merged
merged 46 commits into from
Oct 23, 2023

Conversation

ValentinaIancu-Gini
Copy link
Contributor

Add UI for IBAN detection

PIA-4522

zladzeyka and others added 30 commits September 13, 2023 16:10
… a method for detecting IBAN, remove public access from override methods

PIA-4356
Fix compile errors in Camera with XCode 14.2

PIA-4356
…x lint issues, rename `extractIBANS` -> IBANRecogniser

PIA-4356
…upported

- the IBAN detection will work on devices that have the minimum version iOS 13 but the SDK should be supported also for devices with iOS 12

PIA-4522
…e` loading indicator style on Review screen

PIA-4522
….com:gini/gini-mobile-ios into PIA-4522-UI-for-IBAN-detection-on-device-iOS
@ValentinaIancu-Gini ValentinaIancu-Gini self-assigned this Oct 17, 2023
@ValentinaIancu-Gini ValentinaIancu-Gini changed the base branch from PIA-4356_on_device_iban_detection to main October 18, 2023 11:56
ValentinaIancu-Gini and others added 11 commits October 18, 2023 13:58
# Conflicts:
#	BankSDK/GiniBankSDKExample/GiniBankSDKExample.xcodeproj/project.pbxproj
#	CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Camera/CameraPreviewViewController.swift
- fix the detection of the IBAN when the flow is starting from PhotoPayment button

PIA-4522
…detected qr is invalid and no IBAN in the screen

PIA-4522
….com:gini/gini-mobile-ios into PIA-4522-UI-for-IBAN-detection-on-device-iOS
…alization, IBAN format to display, position of the IBAN detection on iPad in portrait orientation

- cleanup code
PIA-4522
…ring and UIActivityIndicatorView, rename localization strings

- rename: IBANs -> ibans; setLargeStyle -> applyLargeStyle; setZoomForSmallText -> applyZoomForSmallText
- code cleanup: remove unused code, extract Constants
PIA-4522
@ValentinaIancu-Gini ValentinaIancu-Gini marked this pull request as ready for review October 19, 2023 11:15
Copy link
Collaborator

@zladzeyka zladzeyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed together with @ValentinaIancu-Gini

@zladzeyka zladzeyka merged commit 977fed7 into main Oct 23, 2023
22 checks passed
@zladzeyka zladzeyka deleted the PIA-4522-UI-for-IBAN-detection-on-device-iOS branch October 23, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants