Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pia 4300 add privacy manifest v1 #403

Merged
merged 15 commits into from
Sep 4, 2023
Merged

Conversation

ValentinaIancu-Gini
Copy link
Contributor

@ValentinaIancu-Gini ValentinaIancu-Gini commented Aug 21, 2023

  • Add PrivacyInfo manifest file to all Gini sdks

…APILibrary

- declared that the SDK is collecting user's document photos for app functionality purposes
- declared that the SDK is collecting user's device info(deviceModel, onName, osVersion) for logging errors

PIA-4294
- declared usage of `UserDefaults` as a required reason API

PIA-4294
- declared usage of `UserDefaults` as a required reason API
- declared that the SDK is collecting user's document photos for app functionality purposes
- declared that the SDK is collecting user's device info(deviceModel, onName, osVersion) to logging the errors

PIA-4294
…APILibrary

- add missing reason of collecting the user's device information

PIA-4294
- add reason for using `UserDefaults` as a required reason API

PIA-4294
- add reason for using `UserDefaults` as a required reason API

PIA-4294
@ValentinaIancu-Gini ValentinaIancu-Gini self-assigned this Aug 21, 2023
@ValentinaIancu-Gini ValentinaIancu-Gini marked this pull request as ready for review August 25, 2023 15:05
Base automatically changed from PIA-4294-Check-Gini-SDKs-with-Xcode-15-beta-on-iOS-17-v1xx to 1.x.x August 29, 2023 10:17
…`NSPrivacyCollectedDataTypePurposeOther` for type `Other Diagnostic Data`

- just `App functionality` reason should be enough for now

PIA-4300
…`NSPrivacyCollectedDataTypePurposeOther` for type `Other Diagnostic Data`

- just `App functionality` reason should be enough for now

PIA-4300
- `Other Diagnostic Data` should be linked to user

PIA-4300
Copy link
Collaborator

@zladzeyka zladzeyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ValentinaIancu-Gini Great progress
Please add the Payment info to the privacy manifests, remove other purposes of data where we don't need it, and add manifests to the pinning SDKs 🙏

- add the usage of `File timestamp` API
- declare that some `PaymentInfo` are collected

PIA-4300
Copy link
Collaborator

@zladzeyka zladzeyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ValentinaIancu-Gini Could you please the content of the privacy manifest from Gini Bank API Library inside Gini Capture SDK and Gini Bank SDK?
I think let's better overdo than underdo - it will be much easier for our customers to see the full manifest in Gini Bank SDK than navigate and aggregate from all dependencies manually.

…y `PrivacyInfo` file

- add the content of the privacy manifest from Gini Bank API Library inside Gini Capture SDK

PIA-4300
…PrivacyInfo` file

- add the content of the privacy manifest from Gini Bank API Library inside Gini Bank SDK

PIA-4300
@ValentinaIancu-Gini
Copy link
Contributor Author

@zladzeyka I've updated the PR with the extra information from the GiniCaptureSDK and the GiniBankSDK PrivacyInfo files that were declared in the GiniBankAPILibrary

Copy link
Collaborator

@zladzeyka zladzeyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊🎉👍🏻 Great success!

@zladzeyka zladzeyka merged commit 61e8d07 into 1.x.x Sep 4, 2023
20 checks passed
@zladzeyka zladzeyka deleted the PIA-4300-Add-privacy-manifest-v1 branch September 4, 2023 08:44
ValentinaIancu-Gini pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants