Merge branch 'refacto-and-prep-for-private-storage-account' into make…

…-azure-storage-accounts-private
giantswarm · Dec 5, 2024 · 35319cc · 35319cc
2 parents 3fd7996 + 8be2cde
commit 35319cc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -1,7 +1,7 @@
 version: 2.1
 
 orbs:
-  architect: giantswarm/[email protected].1
+  architect: giantswarm/[email protected].2
 
 jobs:
   unit-tests:

diff --git a/internal/pkg/service/objectstorage/cloud/azure/storage.go b/internal/pkg/service/objectstorage/cloud/azure/storage.go
@@ -86,7 +86,7 @@ func (s AzureObjectStorageAdapter) ExistsBucket(ctx context.Context, bucket *v1a
 	return s.existsContainer(ctx, bucket, storageAccountName)
 }
 
-// CreateBucket creates the Storage Account if it not exists AND the Storage Container
+// / CreateBucket creates the Storage Account if it not exists AND the Storage Container
 // CreateBucket creates a bucket in Azure Object Storage.
 // It checks if the storage account exists, and if not, it creates it.
 // Then, it creates a storage container within the storage account.
@@ -121,8 +121,6 @@ func (s AzureObjectStorageAdapter) CreateBucket(ctx context.Context, bucket *v1a
 		return err
 	}
 
-	// TODO create a CNAME record in the private zone
-
 	if err := s.upsertContainer(ctx, bucket, storageAccountName); err != nil {
 		return err
 	}