Implement values override merging #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcus Noble <[email protected]>
Signed-off-by: Marcus Noble <[email protected]>
Signed-off-by: Marcus Noble <[email protected]>
ssyno
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the values loading logic to merge any provided values on top of the default values provided in this module.
Also
clusterbuilderupdated to take in a slice of values overrides that are layered ontop of the default values and the needed refactoring to support this.In the future I anticipate the
standupCLI to be able to apply "patches" to the values to configure functionality without needing the user to provide values files. For example, a CLI flag to disable the use of spot instances could be implemented by having a patch file that overrides the CAPA values like we currently do in our Tekton Task.Towards: https://github.com/giantswarm/giantswarm/issues/30661
Checklist