Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial release of cluster-standup-teardown module #4

Merged
merged 7 commits into from
Apr 26, 2024
Merged

Initial release of cluster-standup-teardown module #4

merged 7 commits into from
Apr 26, 2024

Conversation

AverageMarcus
Copy link
Member

@AverageMarcus AverageMarcus commented Apr 25, 2024 •
edited
Loading

What does this PR do?

Towards https://github.com/giantswarm/giantswarm/issues/30661

Added

  • ClusterBuilder for CAPA, CAPV, CAPVCD, CAPZ and EKS along with default values for each
  • standup and teardown modules for use in other projects
  • standup and teardown CLIs
  • Dockerfile containing the two CLIs

The majority of this code is copied over from cluster-test-suites and modified slightly to make it more useful across multiple applications.

Still outstanding but not to be included in this PR:

  • Merging of values files (currently any provided values files overrides the ones found in this repo)

Checklist

  • CHANGELOG.md has been updated

@AverageMarcus AverageMarcus requested a review from a team as a code owner April 25, 2024 14:53
@AverageMarcus
Added cli documentation
32de9db 
Signed-off-by: Marcus Noble <[email protected]>
@AverageMarcus
Clean go mod
d39d8ac 
Signed-off-by: Marcus Noble <[email protected]>
@AverageMarcus
Handle lint issues
06de4f1 
Signed-off-by: Marcus Noble <[email protected]>
@AverageMarcus
Added nancy ignore
9a706cf 
Signed-off-by: Marcus Noble <[email protected]>
@AverageMarcus
Switch to using go-test instead of go-build
70d7693 
Signed-off-by: Marcus Noble <[email protected]>
mcharriere
mcharriere reviewed Apr 26, 2024
View reviewed changes
pkg/clusterbuilder/providers/capa/cluster.go Outdated
type PrivateClusterBuilder struct{}

// NewClusterApp builds a new private CAPA cluster App
func (c *PrivateClusterBuilder) NewClusterApp(clusterName string, orgName string, clusterValuesFile string, defaultAppsValuesFile string) *application.Cluster {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in case I'm missing something. is it actually possible to create a private cluster from the standup cli?

Last time I tried it needed some code changes. If it's a missing feature and you have it under the radar, please ignore :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't currently as it wasn't needed by any of the test pipelines.

@mcharriere
Copy link

I find it weird that the pkg/clusterbuilder/providers doesn't follow the provider names from https://github.com/giantswarm/clustertest/blob/main/pkg/application/cluster_app.go#L23.

leaving that aside, the PR looks good in general

@AverageMarcus
Copy link
Member Author

I find it weird that the pkg/clusterbuilder/providers doesn't follow the provider names from giantswarm/clustertest@main/pkg/application/cluster_app.go#L23.

Naming is hard 😅 The term provider means different things in different context and it get super confusing 😞 I might see if I can clean that up somewhat. I don't think switching these to the same as the providers you linked to is best though as importing cloud-director as a module is a pain and needs renaming when importing. We've also have a bunch of confusion about if it's cloud-director or clouddirector etc.

@AverageMarcus
Copy link
Member Author

Once change I have done based on that is to move the EKS builder under capa. It doesn't make sense to be split out in this module (but makes sense in cluster-test-suites as triggered by different PRs).

@AverageMarcus
Copy link
Member Author

Tested in cluster-test-suites here: giantswarm/cluster-test-suites#273

I'm going to merge and release as v1.0.0

@AverageMarcus AverageMarcus merged commit 159a137 into main Apr 26, 2024
4 checks passed
@AverageMarcus AverageMarcus deleted the initial_release branch April 26, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcharriere mcharriere mcharriere left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AverageMarcus @mcharriere