Update utils django 4 compatible #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-Hoey
reviewed
May 30, 2023
| @@ -1,3 +1,6 @@ | |||
| ## 1.2.0 | |||
There was a problem hiding this comment.
Could this be 1.1 instead?
| @@ -9,7 +9,7 @@ | |||
| from django.db import models | |||
| from django.forms import Media, Textarea | |||
| from django.forms.utils import flatatt | |||
| from django.utils.encoding import force_text | |||
| from django.utils.encoding import force_str | |||
There was a problem hiding this comment.
Do you know if force_str is available in django<4?
It could be worth having this is a "if django version <4 then use force_text, otherwise use force_ste"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Summary
force_text -> force_str
affects rich_text plugin