Skip to content
This repository has been archived by the owner on Jun 14, 2020. It is now read-only.

Change repoScaleHint to commit count #174

Merged
merged 2 commits into from
Oct 15, 2018
Merged

Conversation

styfle
Copy link
Contributor

@styfle styfle commented Oct 14, 2018

Before this PR, the hint would show "this seems to be a medium project" which is not very helpful since it already shows medium in the badge.

image

This PR changes the hint to display the commit count which gives a better idea of why it's ranked as "medium" project.

@lourot
Copy link
Member

lourot commented Oct 15, 2018

Awesome, I totally agree, see #159. @brillout I know you actually want to do more in this area but this looks like a good short-term move to me. What do you think?

@lourot
Copy link
Member

lourot commented Oct 15, 2018

@styfle by the way a while ago we used to show this data as the amount of non-merge commits (that's why this value is usually a bit lower than the amount of commits displayed on GitHub). You might want to be more precise, or you might prefer to keep this sentence short, I have no strong preference personally.

@brillout validated locally. As far as I'm concerned we can merge :)

@brillout
Copy link
Collaborator

Agree as well.

Thanks!

@brillout brillout merged commit 382b638 into ghuser-io:master Oct 15, 2018
@styfle styfle deleted the patch-1 branch October 15, 2018 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants