Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCS: Response cache headers (GSI-1243) #77

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

DCS: Response cache headers (GSI-1243) #77

wants to merge 9 commits into from

Conversation

TheByronHimes
Copy link
Member

@TheByronHimes TheByronHimes commented Dec 24, 2024 •
edited
Loading

Added cache-control header with max-age to the response for the main endpoint GET /objects/{object_id}.

The value used for max-age is set to the config value presigned_url_expires_after.
The primary integration test was updated to check for the header.

@TheByronHimes TheByronHimes marked this pull request as ready for review December 24, 2024 14:41
@TheByronHimes
Remove cache buffer thing
a18d00c 
Make the client use something like min-fresh in requests for ensuring a good buffer
@TheByronHimes TheByronHimes marked this pull request as draft December 24, 2024 16:40
@TheByronHimes TheByronHimes marked this pull request as ready for review December 24, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mephenor mephenor Awaiting requested review from mephenor

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TheByronHimes