Cleanup #447
Merged
Cleanup #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smorimoto
force-pushed
the
cleanup
branch
10 times, most recently
from
49272f9
to
57ff580
Compare
|
Ready to merge! |
|
Gentle ping |
gfngfn
reviewed
Jul 30, 2024
gfngfn
reviewed
Jul 30, 2024
smorimoto
force-pushed
the
cleanup
branch
4 times, most recently
from
5dd8853
to
4713592
Compare
smorimoto
commented
Aug 4, 2024
|
@gfngfn Ready to merge! |
smorimoto
commented
Aug 4, 2024
Comment on lines
-22
to
+19
| - "4.14" | ||
| - 4 |
There was a problem hiding this comment.
Specify 4 instead of 4.14 to let setup-ocaml always lookup the latest OCaml 4 variant!
Signed-off-by: Sora Morimoto <[email protected]>
|
Thank you so much for arranging! |
|
Oops, merging failed and the CI workflows started to run again 😕 |
smorimoto
commented
Aug 4, 2024
| let version = | ||
| match Build_info.V1.version () with | ||
| | None -> "dev" | ||
| | Some v -> Build_info.V1.Version.to_string v |
There was a problem hiding this comment.
Do not forget to add a version field to the opam file during release process!
|
Oops 😅 |
|
Thanks a lot @gfngfn! |
|
Successfully merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
genversionwithdune-build-infosatysfi.opam)