Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pervasives -> Stdlib #446

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Pervasives -> Stdlib #446

merged 1 commit into from
Jul 29, 2024

Conversation

smorimoto
Copy link
Contributor

The Pervasives module is no longer included in OCaml 5.0, and Stdlib is the recommended replacement. Stdlib itself has been included since OCaml 4.07 and is stable enough.

@smorimoto
Copy link
Contributor Author

smorimoto commented Jul 4, 2024

This should allow you to add support for OCaml 5 by just updating your forked camlpdf!

@smorimoto
Copy link
Contributor Author

smorimoto commented Jul 4, 2024

The build error occurs because the certificate for gust.org.pl has expired, but is not directly related to this PR 🤷‍♂️

@smorimoto
Copy link
Contributor Author

smorimoto commented Jul 4, 2024

It might be a good idea to create a repository like ocaml/opam-source-archives and archive font files etc. in a stable place.

You can still download the font file here: https://web.archive.org/web/https://www.gust.org.pl/projects/e-foundry/latin-modern/download/lm2.004otf.zip

Signed-off-by: Sora Morimoto <[email protected]>
@smorimoto
Copy link
Contributor Author

@gfngfn Upstream issue is resolved!

@gfngfn gfngfn added the build label Jul 8, 2024
@gfngfn gfngfn added this to the v0.0.12 milestone Jul 8, 2024
@smorimoto
Copy link
Contributor Author

Gentle ping

@gfngfn gfngfn merged commit 9882630 into gfngfn:master Jul 29, 2024
3 checks passed
@gfngfn
Copy link
Owner

gfngfn commented Jul 29, 2024

Thanks! (& sorry for the late response 🙏)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants