Let extra_syntaxes_and_themes
reference builtin syntaxes
#2738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1607
Closes #1678
This lets syntax definitions in
extra_syntaxes_and_themes
reference builtin syntaxes (byscope:
orinclude:
or similar).Unfortunately, re-building the
SyntaxSet
is rather expensive. On my (small) personal website, this makes Zola render my site in 469ms rather than 63ms — a slowdown of nearly 8x!We could potentially mitigate this by serializing the computed
SyntaxSet
to a file, for example with acached::DiskCache
, but I don't see existing caching infrastructure so I'm not sure if that's a good tradeoff.Is this wanted? The performance cost is not worth it with the current implementation, but maybe we can optimize it?
Code changes
(Delete or ignore this section for documentation changes)
next
branch?If the change is a new feature or adding to/changing an existing one: