add optional "filter" type to image resize function #2623
Conversation
|
I'm not sure if I have incorrectly configured something, but it seems that running |
|
|
| "catmullrom" => FilterType::CatmullRom, | ||
| "gaussian" => FilterType::Gaussian, | ||
| _ => return Err(anyhow!("Invalid filter type: {}", filter)), | ||
| }; |
There was a problem hiding this comment.
Can we convert directly to the filter type from the image crate and skip our own?
There was a problem hiding this comment.
I went with a custom type because FilterType from the image crate is not Hash, so it breaks downstream functionality when the processed image paths are generated.
There was a problem hiding this comment.
I've just made a PR to impl it, let's see if it works
There was a problem hiding this comment.
i think it's released in the most recent version
|
@aaron404 are you interested in updating that PR? |
|
@Keats I think I have missed something. You mentioned you made a PR to impl it (I assume impl |
|
It's image-rs/image@02a4928 |
|
It looks like we also need FilterType to impl |
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one:
filterparameter to theresize_imagefunction. It defaults tolanczos3which is what was previously hardcoded. I had to add a mirror of theFiltertype from theimagecrate to implHashfor it. I'm not sure if there's a cleaner way to do this.