Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ypkg: Move GIR files to devel #88

Merged
merged 1 commit into from
Sep 15, 2024
Merged

ypkg: Move GIR files to devel #88

merged 1 commit into from
Sep 15, 2024

Conversation

ReillyBrogan
Copy link
Contributor

No description provided.

Signed-off-by: Reilly Brogan <[email protected]>
Copy link
Contributor

@joebonrichie joebonrichie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a possible nit otherwise looks good

@@ -210,6 +210,9 @@ def __init__(self, spec):
# Vala..
self.add_pattern("/usr/share/vala*/vapi/*", "devel")

# GIR bindings for gobject
self.add_pattern("/usr/share/gir-1.0/*.gir", "devel")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: possibly glob -1.0 incase this gets bumped in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been -1.0 for at least 8 years now and if they do change the format/path I'd rather we look into it explicitly.

@joebonrichie joebonrichie merged commit 56037dc into master Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants