GCC cleanup #3377
Merged
GCC cleanup #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went through this package and cleaned it up substantially. Much of the package recipe hasn't been touched since it's initial conversion to ypkg, and many patterns referred to files that haven't been built in years. I also went through all existing configure options and removed any that no longer made sense . Functional changes: - Remove libssp. The functionality of this is also entirely implemented in glibc, so just use that implementation instead. Note that building with SSP by default is still enabled, the two are independent functionalities of GCC. - Enable backtrace in libstdcxx. This is needed for updating PCSX2. - Move files around to different subpackages. Much of what was in libgcc and libstdc++ were unnecessary for runtime so those packages were slimmed down substantially by moving things like the address sanitizer libraries into gcc or g++. Static libraries were also moved into gcc directly as they were essentially unusable without gcc installed anyway. - Remove several old symlinks that as far as I can tell are unnecessary. No other distro I checked ships those symlinks and there is no indication of what they were for or meant to work around. As far as I can tell packages build fine without them. - Restore gcov-dump (I couldn't replicate the issue the comment referred to) - Removed a patch changing the cost of auto-vectorization. There was never any movement on benchmarking the difference this makes and so let's just stick with upstream defaults here. - Ensure that gcc libs are never built with rpath Non-functional cleanups: - Add a note on how to speed up the build substantially for those who are iterating on improving the GCC package - Remove a number of package patterns that referred to files that no longer exist in gcc. - Remove an old patch for always enabling SSP. The `--enable-default-ssp` flag does essentially the same thing - Remove `--enable-__cxa_atexit` as gcc enables it by default on our targets anyway - Remove `--enable-clocale=gnu` as gcc enables it by default on our targets anyway - Remove `--enable-gold` as it's the default configuration - Remove `--enable-ld=default` as it's also the default configuration - Remove `--enable-lto` as it's also the default, and GCC will actually throw an error if you try to disable it - Remove `--with-gnu-ld` as it's the default on non-Android Linux - Add `--enable-checking=release` as it enables build checks that are enabled when building from a release tar but disabled when building from git source. Since we may need to build from git source at some point we can add this to ensure build consistency. - Add `--enable-host-shared` as it ensures that libs are built with certain flags that we need - Change `--enable-threads=posix` to `--enable-threads=yes`. POSIX threads are the default on Linux when threads are enabled Signed-off-by: Reilly Brogan <[email protected]>
Signed-off-by: Reilly Brogan <[email protected]>
Signed-off-by: Reilly Brogan <[email protected]>
Merged
joebonrichie
approved these changes
Jul 26, 2024
ReillyBrogan
added a commit
that referenced
this pull request
Jul 27, 2024
**Summary** - Update GCC to v14.1 - Rebuild glibc and binutils Note that this PR builds on #3377, and the commits won't make sense unless that's merged. This PR is draft until then. Additionally since there needs to be another round of rebuilds for these packages to complete bootstrapping I've left GCC building in a faster mode. I'll switch back to the slower profile for the second round of rebuilds. Also, building GCC with PIE has added a lot of items to the ABI report. I took a look in the diff at the actual changes to libgcc and libstd++ and there was nothing that looked problematic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary