-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support passing provider custom secrets to TACOs #225
Open
fpacifici
wants to merge
30
commits into
main
Choose a base branch
from
fpacifici/support_custom_secrets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These secrets are global (across all slices)? Trying to think if there are cases where we might need to have different secrets depending on what you're applying. GCP is the main one that sticks out but that is already handled by using OIDC authentication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soem Terraform provider need secrets for authentication. For example the datadog one
and the pagerduty one.
TACOs does not provide, as of today, a way to provide those secrets as they are specific
to the slices and providers the client is using.
This PR adds a new
secret
to all the acitons where the secret is needed: plan, apply,drift detection. This secret is provided as a json object where each key represents a
secret.
The
setup
action unpacks it and sets an environment variable for terraform per secret.It also ensures all the secret values are masked.
Secrets are going to be provided to terraform as variable by setting
TF_VAR_
environmentvariables. This happens once per secret.
See it working on this PR https://github.com/getsentry/ops/actions/runs/9521154268.
I checked that the secret is never in visible in the log.