Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spotlight): Add self-contained spotlight binary creation #559

Open
wants to merge 105 commits into
base: main
Choose a base branch
from

Conversation

BYK
Copy link
Member

@BYK BYK commented Nov 12, 2024

This PR adds a new release type which is a self-contained system-independent CLI akin to running npx @spotlightjs/spotlight but without any node or npx or any other requirements on the system.

It also changes how we serve the static assets: instead of serving the entire folder, which can be dangerous as it allows access to arbitrary files, we now use the manifest.json generated when compiling it and only serve files listed there, directly from memory. This should also increase the performance.

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 6:04pm

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.15%. Comparing base (ea666ac) to head (ce60b91).
Report is 134 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   29.00%   31.15%   +2.14%     
==========================================
  Files          60       83      +23     
  Lines        4144     5030     +886     
  Branches       72       99      +27     
==========================================
+ Hits         1202     1567     +365     
- Misses       2942     3463     +521     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants