-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(eap) Remove old attributes tables #6375
Open
evanh
wants to merge
6
commits into
master
Choose a base branch
from
evanh/fix/remove-old-attributes-tables
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a99dfa1
ref(eap) Remove old attributes tables
evanh 8b22fe5
remove backwards ops
evanh 0bcbbb1
cleanup
evanh a561c8f
fix: Fix SyntaxWarning in Python 3.12
evanh e786b2f
Revert "fix: Fix SyntaxWarning in Python 3.12"
evanh 284ed50
Merge branch 'master' into evanh/fix/remove-old-attributes-tables
evanh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
32 changes: 32 additions & 0 deletions
32
snuba/snuba_migrations/events_analytics_platform/0016_remove_old_span_attribute_table.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
from __future__ import annotations | ||
|
||
from typing import Sequence | ||
|
||
from snuba.clusters.storage_sets import StorageSetKey | ||
from snuba.migrations.migration import ClickhouseNodeMigration | ||
from snuba.migrations.operations import DropTable, OperationTarget, SqlOperation | ||
|
||
|
||
class Migration(ClickhouseNodeMigration): | ||
blocking = False | ||
storage_set_key = StorageSetKey.EVENTS_ANALYTICS_PLATFORM | ||
|
||
meta_local_table_name = "spans_attributes_meta_local" | ||
meta_dist_table_name = "spans_attributes_meta_dist" | ||
|
||
def forwards_ops(self) -> Sequence[SqlOperation]: | ||
return [ | ||
DropTable( | ||
storage_set=self.storage_set_key, | ||
table_name=self.meta_local_table_name, | ||
target=OperationTarget.LOCAL, | ||
), | ||
DropTable( | ||
storage_set=self.storage_set_key, | ||
table_name=self.meta_dist_table_name, | ||
target=OperationTarget.DISTRIBUTED, | ||
), | ||
] | ||
|
||
def backwards_ops(self) -> Sequence[SqlOperation]: | ||
return [] # All or nothing |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably shouldn't have a backwards ops. We don't want to try and recreate this table if the migration fails