-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(clickhouse): update versions and add 24.3 #6246
base: master
Are you sure you want to change the base?
Conversation
1b41b62
to
15a5e2a
Compare
@@ -56,6 +56,7 @@ class ClickhouseClientSettings(Enum): | |||
"replication_alter_partitions_sync": 2, | |||
"mutations_sync": 2, | |||
"database_atomic_wait_for_drop_and_detach_synchronously": 1, | |||
"allow_suspicious_primary_key": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onkar @mcannizz this setting is to get around the problems in the EAP tables run into issue due to ClickHouse/ClickHouse#61399, I think we discussed before that would should actually fix this migration instead of allowing this setting, but this does seem to work incase we need it for temporary backwards compatibility.
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
bd6ffd3
to
a1088bf
Compare
clickhouse versions of note:
22.8.15.25
: is still used in some test clusters, can update this to be higher once confirmed those test regions aren't needed23.3.19.33
: is still used in sentry development, should probably be updated23.8.11.29
: latest version used for all production clusters and self-hosted and sentry development24.3.5.47
: latest altinity stable build that we want to start including in CI to prep for eventual upgrade this year