Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(clickhouse): update versions and add 24.3 #6246

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MeredithAnya
Copy link
Member

@MeredithAnya MeredithAnya commented Aug 28, 2024

clickhouse versions of note:

  • 22.8.15.25: is still used in some test clusters, can update this to be higher once confirmed those test regions aren't needed
  • 23.3.19.33: is still used in sentry development, should probably be updated
  • 23.8.11.29: latest version used for all production clusters and self-hosted and sentry development
  • 24.3.5.47: latest altinity stable build that we want to start including in CI to prep for eventual upgrade this year

@MeredithAnya MeredithAnya requested a review from a team as a code owner August 28, 2024 18:21
@@ -56,6 +56,7 @@ class ClickhouseClientSettings(Enum):
"replication_alter_partitions_sync": 2,
"mutations_sync": 2,
"database_atomic_wait_for_drop_and_detach_synchronously": 1,
"allow_suspicious_primary_key": 1,
Copy link
Member Author

@MeredithAnya MeredithAnya Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onkar @mcannizz this setting is to get around the problems in the EAP tables run into issue due to ClickHouse/ClickHouse#61399, I think we discussed before that would should actually fix this migration instead of allowing this setting, but this does seem to work incase we need it for temporary backwards compatibility.

Copy link

codecov bot commented Nov 20, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
474 1 473 1
View the top 1 failed tests by shortest run time
tests.admin.test_api::test_query_trace_bad_query
Stack Traces | 0.264s run time
Traceback (most recent call last):
  File ".../tests/admin/test_api.py", line 355, in test_query_trace_bad_query
    assert (
AssertionError: assert 'Exception: Unknown expression or function identifier' in "DB::Exception: Missing columns: 'asdasds' while processing query: 'SELECT count(asdasds) FROM errors_local SETTINGS log_profile_events = 1', required columns: 'asdasds'. Stack trace:\n\n0. DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000c61ff37 in ................................................/usr/bin/clickhouse\n1. DB::Exception::Exception(PreformattedMessage&&, int) @ 0x0000000007156ef1 in ................................................/usr/bin/clickhouse\n2. DB::TreeRewriterResult::collectUsedColumns(std::shared_ptr<DB::IAST> const&, bool, bool) @ 0x000000001221ab99 in ................................................/usr/bin/clickhouse\n3. DB::TreeRewriter::analyzeSelect(std::shared_ptr<DB::IAST>&, DB::TreeRewriterResult&&, DB::SelectQueryOptions const&, std::vector<DB::TableWithColumnNamesAndTypes, std::allocator<DB::TableWithColumnNamesAndTypes>> const&, std::vector<String, std::allocator<String>> const&, std::shared_ptr<DB::TableJoin>) const @ 0x000000001221f801 in ................................................/usr/bin/clickhouse\n4. DB::InterpreterSelectQuery::InterpreterSelectQuery(std::shared_ptr<DB::IAST> const&, std::shared_ptr<DB::Context> const&, std::optional<DB::Pipe>, std::shared_ptr<DB::IStorage> const&, DB::SelectQueryOptions const&, std::vector<String, std::allocator<String>> const&, std::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::shared_ptr<DB::PreparedSets>)::$_0::operator()(bool) const @ 0x0000000011ed191c in ................................................/usr/bin/clickhouse\n5. DB::InterpreterSelectQuery::InterpreterSelectQuery(std::shared_ptr<DB::IAST> const&, std::shared_ptr<DB::Context> const&, std::optional<DB::Pipe>, std::shared_ptr<DB::IStorage> const&, DB::SelectQueryOptions const&, std::vector<String, std::allocator<String>> const&, std::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::shared_ptr<DB::PreparedSets>) @ 0x0000000011ec5975 in ................................................/usr/bin/clickhouse\n6. DB::InterpreterSelectWithUnionQuery::InterpreterSelectWithUnionQuery(std::shared_ptr<DB::IAST> const&, std::shared_ptr<DB::Context>, DB::SelectQueryOptions const&, std::vector<String, std::allocator<String>> const&) @ 0x0000000011f74948 in ................................................/usr/bin/clickhouse\n7. DB::InterpreterFactory::get(std::shared_ptr<DB::IAST>&, std::shared_ptr<DB::Context>, DB::SelectQueryOptions const&) @ 0x0000000011e7b91e in ................................................/usr/bin/clickhouse\n8. DB::executeQueryImpl(char const*, char const*, std::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum, DB::ReadBuffer*) @ 0x00000000122bf58a in ................................................/usr/bin/clickhouse\n9. DB::executeQuery(String const&, std::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum) @ 0x00000000122bb5b5 in ................................................/usr/bin/clickhouse\n10. DB::TCPHandler::runImpl() @ 0x0000000013137519 in ................................................/usr/bin/clickhouse\n11. DB::TCPHandler::run() @ 0x00000000131498f9 in ................................................/usr/bin/clickhouse\n12. Poco::Net::TCPServerConnection::start() @ 0x0000000015b42834 in ................................................/usr/bin/clickhouse\n13. Poco::Net::TCPServerDispatcher::run() @ 0x0000000015b43a31 in ................................................/usr/bin/clickhouse\n14. Poco::PooledThread::run() @ 0x0000000015c7a667 in ................................................/usr/bin/clickhouse\n15. Poco::ThreadImpl::runnableEntry(void*) @ 0x0000000015c7893c in ................................................/usr/bin/clickhouse\n16. ? @ 0x00007f0d79052609 in ?\n17. ? @ 0x00007f0d78f77353 in ?\n"

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants