Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): add wildcard support to MQL parser #5972

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shellmayr
Copy link
Member

Contributes to getsentry/sentry#69852

Copy link

codecov bot commented May 24, 2024

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 261 tests with 1 failed, 260 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message
Testsuite:
pytest

Test name:
tests.test_metrics_mql_api.TestGenericMetricsMQLApi::test_retrieval_complex

Envs:
- default
Traceback (most recent call last):
File ".../snuba/tests/test_metrics_mql_api.py", line 277, in test_retrieval_complex
assert response.status_code == 200, data
AssertionError: {'error': {'message': "AttributeError: 'str' object has no attribute 'contains_wildcard'", 'type': 'invalid_query'}}
assert 400 == 200
+ where 400 = <WrapperTestResponse 144 bytes [400 BAD REQUEST]>.status_code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant