Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase max resolution for jitter from 1min to 2min #5862

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Increase max resolution for jitter from 1min to 2min #5862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eedff9f
Update the max resolution for jitter to be 900. This will help balanc…
saponifi3d May 3, 2024
c6298e7
bump it up to 30min
saponifi3d May 3, 2024
dfb55de
tune the resolution for jitter a bit, only do it for 2min initially
saponifi3d May 3, 2024
7cc49e8
Bump test to 3, we'll probably want to add more tests around this and…
saponifi3d May 3, 2024
9f1f07e
Merge branch 'master' into jcallender/increase-jitter-resolution
saponifi3d May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion snuba/settings/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ class RedisClusters(TypedDict):
# We expect to remove them after all storages and migration groups have been migrated.
READINESS_STATE_FAIL_QUERIES: bool = True

MAX_RESOLUTION_FOR_JITTER = 60
MAX_RESOLUTION_FOR_JITTER = 120

# These contexts will not be stored in the transactions table
# Example: {123: {"context1", "context2"}}
Expand Down
4 changes: 2 additions & 2 deletions tests/subscriptions/test_task_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,15 +126,15 @@
pytest.param(
JitteredTaskBuilder(),
"jittered",
[(ALIGNED_TIMESTAMP, build_subscription(timedelta(minutes=2), 0))],
[(ALIGNED_TIMESTAMP, build_subscription(timedelta(minutes=3), 0))],
[
(
ALIGNED_TIMESTAMP,
ScheduledSubscriptionTask(
datetime.fromtimestamp(ALIGNED_TIMESTAMP),
SubscriptionWithMetadata(
EntityKey.EVENTS,
build_subscription(timedelta(minutes=2), 0),
build_subscription(timedelta(minutes=3), 0),
1,
),
),
Expand Down
Loading