Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trace) issues only collapse trace #81171

Open
wants to merge 2 commits into
base: jb/issues/trace-view
Choose a base branch
from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Nov 22, 2024

We bfs to find collapsed nodes, because we want to preserve the tree structure, this means that it is possible to have consecutive collapsed nodes at different levels in the tree. We can fix this by doing a second pass over the list of the nodes in the tree and collapse any siblings. I also removed the condition to not render the errors only trace view as this seems to be a case that we handle in our new design.

@JonasBa JonasBa requested a review from a team as a code owner November 22, 2024 03:49
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ce/newTraceDetails/traceModels/issuesTraceTree.tsx 93.33% 1 Missing ⚠️
...nce/newTraceDetails/traceRow/traceCollapsedRow.tsx 85.71% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           jb/issues/trace-view   #81171   +/-   ##
=====================================================
  Coverage                 78.35%   78.35%           
=====================================================
  Files                      7221     7221           
  Lines                    317711   317727   +16     
  Branches                  43833    43838    +5     
=====================================================
+ Hits                     248931   248947   +16     
  Misses                    62450    62450           
  Partials                   6330     6330           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant