Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): handle uniqueness of ApiAuthorization per org #81160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(auth): handle uniqueness of ApiAuthorization per org #81160

wants to merge 1 commit into from
+48 −3

Conversation

sentaur-athena
Copy link
Member

I added a new unique index in #80996 and this PR is using it in code.

Basically:

  1. If organization id is null then ApiAuthorization of an app must be unique per user
  2. If organization id is not null then ApiAuthorization of an app must be unique per user and org (per organization member)

@sentaur-athena sentaur-athena requested a review from a team as a code owner November 21, 2024 22:52
@sentaur-athena sentaur-athena requested review from mdtro and a team November 21, 2024 22:53
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 21, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

❌ 611 Tests Failed:

Tests completed Failed Passed Skipped
23117 611 22506 215
View the top 3 failed tests by shortest run time 
tests.snuba.search.test_backend.EventsJoinedGroupAttributesSnubaSearchTest::test_date_filter
Stack Traces | 0.006s run time 
No failure message available
tests.snuba.search.test_backend.EventsJoinedGroupAttributesSnubaSearchTest::test_not_perf_category
Stack Traces | 0.006s run time 
No failure message available
tests.snuba.search.test_backend.EventsJoinedGroupAttributesSnubaSearchTest::test_query_timestamp
Stack Traces | 0.006s run time 
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdtro mdtro Awaiting requested review from mdtro

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sentaur-athena