Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(streamline): Folders for frontend #81146

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Nov 21, 2024

A little more structure, open to suggestions about it, but the long directory made it challenging to scan.

image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #81146       +/-   ##
===========================================
- Coverage   91.92%   80.33%   -11.59%     
===========================================
  Files        3069     7221     +4152     
  Lines      191952   320039   +128087     
  Branches        0    20778    +20778     
===========================================
+ Hits       176457   257116    +80659     
- Misses      15495    62530    +47035     
- Partials        0      393      +393     

@ryan953
Copy link
Member

ryan953 commented Nov 22, 2024

Be more aggressive! Some components in here might've been created to support the new issues design, but I'd be surprised if FoldSection could never be reused by another product (maybe Feedback would reuse that soon!)
For those types of things move them all the way up & out of any folder or sub folder called issues/ so other people can find them, but also the specific stuff that is left is easier to read through too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants