Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(debugfile): Recognize chunk-uploaded Proguard files #81131

Merged
merged 1 commit into from
Nov 22, 2024

Commits on Nov 21, 2024

  1. fix(debugfile): Recognize chunk-uploaded Proguard files

    The `detect_dif_from_path` function does not correctly identify Proguard files which are chunk uploaded because these files have a randomly-assigned temporary path, and the logic tries to guess whether the file is a Proguard file based on its path. However, the `detect_dif_from_path` function also takes an optional `name` option, which for chunk-uploaded files, is the file name that is specified by the client making the assemble call. This has not been a problem yet, since Sentry CLI does not support chunk uploading Proguard files, but we are adding support in getsentry/sentry-cli#2196, and so we need to fix the backend to allow chunk uploads of Proguard files.
    
    Here, we update the logic to check both the `path` and the `name` for potentially matching a Proguard file.
    szokeasaurusrex committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9b53f32 View commit details
    Browse the repository at this point in the history