Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(similarity): Add logging for over 30 system frames #81130

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jangjodi
Copy link
Member

Add logging for events with stacktraces with over 30 system-only frames

@jangjodi jangjodi requested a review from a team as a code owner November 21, 2024 16:53
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 21, 2024
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we follow the pattern where we raise the exception we can catch and log then, so no need to pass anything extra into the function

@jangjodi
Copy link
Member Author

if we follow the pattern where we raise the exception we can catch and log then, so no need to pass anything extra into the function

if we raise the exception, would we still be able to return the stacktrace string? I chose to do it this way so the grouping logic would not change yet

Copy link

codecov bot commented Nov 21, 2024

❌ 877 Tests Failed:

Tests completed Failed Passed Skipped
23119 877 22242 215
View the top 3 failed tests by shortest run time
tests.sentry.hybridcloud.services.test_control_organization_provisioning.TestControlOrganizationProvisioningSlugUpdates__InControlMode::test_swap_for_org_without_primary_slug
Stack Traces | 0.005s run time
No failure message available
tests.sentry.hybridcloud.services.test_control_organization_provisioning.TestControlOrganizationProvisioningSlugUpdates__InControlMode::test_swap_with_same_slug
Stack Traces | 0.005s run time
No failure message available
tests.sentry.sentry_apps.test_sentry_app_creator.TestCreator::test_creates_proxy_user
Stack Traces | 0.006s run time
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants