Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ds): Detect health check routes with trailing slash #81117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(ds): Detect health check routes with trailing slash #81117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d1ed0c
feat(ds): Detect health check routes with trailing slash
jan-auer Nov 21, 2024
47b350d
test: Update snapshot
jan-auer Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/sentry/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,19 @@ class InsightModules(Enum):
"*/readyz",
"*/ping",
"*/up",
# Same as above with trailing slash. Relay's pattern matcher cannot handle
# optional trailing slashes.
"*/health/",
"*/healthy/",
"*/healthz/",
"*/_health/",
r"*/\[_health\]/",
"*/live/",
"*/livez/",
"*/ready/",
"*/readyz/",
"*/ping/",
"*/up/",
Comment on lines +793 to +805
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this in Code instead? Automatically duplicate all entries with a slash?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for getsentry/relay#4277 instead.

]


Expand Down
11 changes: 11 additions & 0 deletions tests/sentry/relay/snapshots/test_config/test_get_project_config/REGION.pysnap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,17 @@ config:
- '*/readyz'
- '*/ping'
- '*/up'
- '*/health/'
- '*/healthy/'
- '*/healthz/'
- '*/_health/'
- '*/\[_health\]/'
- '*/live/'
- '*/livez/'
- '*/ready/'
- '*/readyz/'
- '*/ping/'
- '*/up/'
groupingConfig:
enhancements: KLUv_SAYwQAAkwKRs25ld3N0eWxlOjIwMjMtMDEtMTGQ
id: newstyle:2023-01-11
Expand Down
Loading