Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(insights): screen rendering analytic event name incorrect #80413

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix(insights): screen rendering analytic event name incorrect #80413

merged 1 commit into from
Nov 7, 2024
+1 −1

Conversation

DominikB2014
Copy link
Contributor

Copy paste error, we were setting the analyticEventName to screen_load in the screen rendering module.

@DominikB2014 DominikB2014 requested a review from a team as a code owner November 7, 2024 21:16
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 7, 2024
@DominikB2014 DominikB2014 merged commit 2f9d40b into master Nov 7, 2024
44 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/fix-screen-rendering-analytic-event branch November 7, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gggritso gggritso gggritso approved these changes

@edwardgou-sentry edwardgou-sentry Awaiting requested review from edwardgou-sentry

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominikB2014 @gggritso